search

scarpe-team / scarpe

Scarpe - shoes but running on webview
Other
163 stars 28 forks source link

Get rid of Stack and Flow options param #480

Closed noahgibbs closed 10 months ago

noahgibbs commented 11 months ago

Right now Stack and Flow use a weird initialize method that grabs "options" rather than using the now-standard styles keywords. It means Calzini needs to check in options for things like margin.

If I make Stack and Flow print out any non-empty options, it turns out they're only non-empty in three total cases for Stack and Flow for a "rake test" run. For one of them each, the options contains "hidden", which is a normal style and should be passed through as such. For the other two times, one is border (not yet supported) in parse_xl_funnies.

So: options should go away. We should support border using standard Shoes styles. We already support hidden, it's just not being passed correctly because we're doing something weird for Stack and Flow (and by inheritance DocumentRoot.)

noahgibbs commented 11 months ago

Once we do that we can use the same initialize method params for Stack and Flow that we do for all other drawables.

noahgibbs commented 11 months ago

I've fixed the initialize method itself in #485. Still need to add border to all drawables (or finally as an actual drawable?)

noahgibbs commented 10 months ago

Closing this, I'll handle borders elsewhere.