search

scarpe-team / scarpe

Scarpe - shoes but running on webview
Other
162 stars 29 forks source link

Clean up html_attributes #488

Closed noahgibbs closed 9 months ago

noahgibbs commented 9 months ago

We no longer use html_attributes on slots or Para, and it never worked well (setting attributes, not styles, but we used it for styles.)

We should get rid of the remainders of it in Lacci.

Not 100% sure about Span. Can that go too? [Edit: gonna ignore it for now in Span. Span needs a general cleanup along with TextDrawable in general. It can wait for that.]

noahgibbs commented 9 months ago

Ooh, I'm badly wrong here. We no longer pass html_attributes from Lacci as a Shoes-Style, but we 100% use them in Calzini because Scarpe-Webview generates them to do things like hover events. So yeah, should not remove them from Slot. We could use a test to make sure this keeps working, though.

noahgibbs commented 9 months ago

I'm right that using them from Lacci was bad. I just didn't realise we were still using them for e.g. hover and click events.

noahgibbs commented 9 months ago

Okay, I think this was a bad idea. Closing.