HTML CI - Githubissues

scarpe-team / scarpe

Scarpe - shoes but running on webview

Other

163 stars 28 forks source link

HTML CI #492

Closed Schwad closed 10 months ago

Schwad commented 10 months ago

Introduces HTML fixtures for webview. They are generated off of our top-level Ruby example files. Generate or regenerate with bundle exec rake test:regen_fixtures
Check that your changes have not altered the html with bundle exec rake test:check_html_fixtures
- Your change may well result in new HTML and that is okay. But this will make it easier to review the actual HTML diff
Introduces CI check after all prior tests to ensure that developers make this check.
- Example of a failure output on a CI run here: https://github.com/scarpe-team/scarpe/actions/runs/7159731189/job/19493310868

noahgibbs commented 10 months ago

Getting a couple of failures on button rendering not matching up with property order... Not sure why. Also an error on local_font.rb because the CI full file path for the font doesn't match the one from @schwad's machine. There are a few possible ways to fix that...

Schwad commented 10 months ago

Getting a couple of failures on button rendering not matching up with property order... Not sure why. Also an error on local_font.rb because the CI full file path for the font doesn't match the one from @Schwad's machine. There are a few possible ways to fix that...

I'll dig into this and see the best way to resolve

Schwad commented 10 months ago

Another cool thing, like, is being able to drop this raw HTML into your browser and just "look" at it. it's nothing extravagant and maybe I need another higher level div in there but I really like it

noahgibbs commented 10 months ago

Another cool thing, like, is being able to drop this raw HTML into your browser and just "look" at it. it's nothing extravagant and maybe I need another higher level div in there but I really like it

That is really cool. Now I wonder if maybe I need to add a "data URLs only" mode to this asset server thing I'm doing. On the one hand, they're murder on diff size (think 400kb before base64-conversion in Tiranti), but on the other hand you can just view the single html file in the browser and it works.

noahgibbs commented 10 months ago

We could also do the HTML output in a different mode (Calzini render? Minimal styling?). But then it won't look right and may not catch some bugs, or get different bugs not in Tiranti. So maybe not the best idea.

Schwad commented 10 months ago

I've added support for

# html_ci: false

for examples that have issues until we resolve them.