scarpe-team / scarpe

Scarpe - shoes but running on webview
Other
162 stars 29 forks source link

Various fixes related to getting the ovals demo working better. #511

Closed noahgibbs closed 8 months ago

noahgibbs commented 8 months ago

Description

Note that a number of the fixtures changes are to switch back and forth between black and #000000. That's not great, and it's an artifact of how we default colors in several places. Once we have colors in a component I think we'll want to always output RGB hex format, which will take care of that problem. In the mean time, I'm keeping a lot of code that's already in place.

This should be basically compatible with @schwad's oval PR (#507), which focuses on the Lacci side. But if he gets Lacci to handle colours in a more uniform way, we can probably get rid of some of the display-service-side complexity here.

This does not fix "center" for ovals, which will be a different PR. So right now the ovals aren't properly treating the top/left coords as center.

Image(if needed, helps for a faster review)

Screenshot 2023-12-14 at 09 48 55

Checklist