More timeout options for sspec tests

scarpe-team / scarpe

Scarpe - shoes but running on webview

Other

162 stars 29 forks source link

More timeout options for sspec tests #521

Closed noahgibbs closed 9 months ago

noahgibbs commented 9 months ago

Description

Our pre-Shoes-Spec test infrastructure had a bunch of timeout and failure options. Turns out I need some of those for testing display properties, too. So I'm adding them for Shoes-Spec.

Checklist

[X] Run tests locally

noahgibbs commented 9 months ago

Hm. This is succeeding in its tests, but it's not doing quite the right thing. I'll fix it before I merge.

noahgibbs commented 9 months ago

Huh. Calling exit(-1) in a Fiber seems to not be actually exiting the process. Either that or I'm not understanding what's happening somehow.

noahgibbs commented 9 months ago

In a tiny test program, exit called from a Fiber works fine. Maybe it's some kind of Webview thing?

noahgibbs commented 9 months ago

Okay. Worked around this for the cases I care about. Still a large improvement on not having this.

noahgibbs commented 9 months ago

May just merge this. Updating to main in any case.