Closed Nj221102 closed 7 months ago
This looks really good! You can technically just do "props['font_weight']" to get the "or nil" effect rather than using a ternary question-mark-colon operator. But this is good :-)
is it supposed to be :weight
or :font-weight
ok? i mean ig acc to manual it's weight ig?
This looks really good! You can technically just do "props['font_weight']" to get the "or nil" effect rather than using a ternary question-mark-colon operator. But this is good :-)
Thanks for the compliment, should I remove the ternary operator or leave it as it is?
I'm fine with leaving it as-is. You'll need to run "rake test:regenerate_html_fixtures" though -- you added an example and it doesn't have fixture output yet. That's why the test failed above. I'll file a bug to give a better error message when that happens because there's a new example.
I'm fine with leaving it as-is. You'll need to run "rake test:regenerate_html_fixtures" though -- you added an example and it doesn't have fixture output yet. That's why the test failed above. I'll file a bug to give a better error message when that happens because there's a new example.
Have made the requested changes, is it good now.
Thanks! Merged.
Description
I have added the functionality of using font- weight in para -> #471
Image(if needed, helps for a faster review)
Checklist