search

scarpe-team / scarpe

Scarpe - shoes but running on webview
Other
162 stars 29 forks source link

Fix GitHub link #543

Open vikas-chaudhary-2802 opened 6 months ago

vikas-chaudhary-2802 commented 6 months ago

I have fixed the Git Hub Link that fails -> #516 This fix enhances the user experience by ensuring seamless navigation to GitHub via links. It also prevents any disruptions that users might have previously encountered due to this issue.

Video(if needed, helps for a faster review)

https://github.com/scarpe-team/scarpe/assets/147247481/2ea80e25-5a72-4cae-a75e-0c9ab55f28fa

Checklist

noahgibbs commented 6 months ago

Hm. So then it looks like an error still happens, and the JS fails, but now we don't raise an exception in Ruby when it does? Am I understanding correctly?

If so, I'm worried because this will stop failing on essentially all Javascript errors. That does let Ruby continue, but also masks a lot of possible problems that we won't see when they happen.