Closed Nj221102 closed 6 months ago
This looks fine. Would you rather remove the one line for props["margin"] in Calzini? I could also just hit merge -- this is certainly an overall improvement.
This looks fine. Would you rather remove the one line for props["margin"] in Calzini? I could also just hit merge -- this is certainly an overall improvement.
I did add that margin in calzini because i was implementing a feature where margin actually writes to margin when there is only one input , instead of writing to four different specific margins, I think you suggested that as well, when we were talking on discord, if you want i can remove it .
sorry i by mistake pressed the close button instead of comment
I did add that margin in calzini because i was implementing a feature where margin actually writes to margin when there is only one input , instead of writing to four different specific margins, I think you suggested that as well, when we were talking on discord, if you want i can remove it .
I think we definitely do not want to write to the Shoes style margin in that case. But we may want to set the CSS property, as a detail of the Webview implementation. Make sense?
I did add that margin in calzini because i was implementing a feature where margin actually writes to margin when there is only one input , instead of writing to four different specific margins, I think you suggested that as well, when we were talking on discord, if you want i can remove it .
I think we definitely do not want to write to the Shoes style margin in that case. But we may want to set the CSS property, as a detail of the Webview implementation. Make sense?
got that , I am removing the margin , making the commit in 10 mins 👍
@noahgibbs done 👍
Description
Similar to font shorthand, the margin shorthand was being overwritten by default input of specific margin properties. This PR addresses this issue by implementing the following improvements:
Margin Shorthand Property Fix: The margin shorthand property has been fixed by directly mapping it with specific margin properties in Lacci. This means that the margin shorthand will no longer overwrite the margin property. Instead, when there are four inputs in the margin shorthand, it will be split into four parts and sent to the specific margin properties. When there is only one input, it will write directly to the margin shorthand property.
Consistent Input Pattern: The margin shorthand now adheres to the same input pattern as the original Shoes library, which is
[left, top, right, bottom]
.Test Coverage: Tests have been added for the
margin_parse
method, responsible for mapping the margin shorthand to specific properties.Removal of 'Pacifico' Font: The 'Pacifico' font has been removed from the
font_family.rb
example. This font was causing path mismatch issues whenever fixtures were generated, leading to failures in GitHub CI tests. Removing it helps avoid confusion for newcomers until the issue is resolved.Example Illustration: An example has been provided to demonstrate how the margin shorthand now functions.
end