search

scarpe-team / scarpe

Scarpe - shoes but running on webview
Other
162 stars 29 forks source link

Add border as drawable #548

Closed sapienfrom2000s closed 6 months ago

sapienfrom2000s commented 6 months ago

Description

Move from border as style to border as drawable element

maybe solves #498

Image(if needed, helps for a faster review)

border

Checklist

noahgibbs commented 6 months ago

Sorry for taking awhile to get to this... But it looks like some tests are failing. I'll try to look into this soon.

sapienfrom2000s commented 6 months ago

It seems like I need to consider gradient and curve as well

gintama91 commented 6 months ago

I think generating fixtures should fix that background_with_image test too

bundle exec rake test:regenerate_html_fixtures

noahgibbs commented 6 months ago

Nice! Tests passing, merged.