cmake fixes and CI with cmake - Githubissues

scarrazza / apfel

A PDF Evolution Library

http://apfel.mi.infn.it/

GNU General Public License v3.0

12 stars 9 forks source link

cmake fixes and CI with cmake #46

Closed andriish closed 1 year ago

andriish commented 1 year ago

Hi @scarrazza, here is a simple CI + some cmake fixes:

CI:
- Runs on MacOSX in native Actions MacOS
- Runs on latest Fedora in a Docker container
- For both cases uses the lhapdf
- All dependencies are installed from binary repositories
- All options are turned on: LHAPDF, SWIG, testing
- Workflow is quite cheap: ~ 2m30sec
- Scheduled builds are enabled
- Regular rebuilds with fedora::latests assures the most updated container with all the dependencies
- Cmake fix:
- The Fortran-C intrface function has a correct name
- More advanced approach to PDF downloads, e.g. checks of checksums, which is useful when HepForge is down

Same as #45

Tag @AleCandido

alecandido commented 1 year ago

I made a couple of small comments, but they are small suggestions. I'd say that it's pretty good 👍

andriish commented 1 year ago

If there are two approvals, it makes sense to merge, no? @AleCandido @scarrazza