search

scarvalhojr / aoc-cli

Advent of Code command-line tool
MIT License
249 stars 17 forks source link

fix: Proper display of stars for 2022 Day 25 #15

Closed WillLillis closed 11 months ago

WillLillis commented 11 months ago

Thanks so much for this tool! I noticed that when running the calendar option for 2022, the stars for Day 25 weren't showing up. From what I can tell something in the regex gets messed up when the html for the balloon animations get added. I tried fixing this by adding a check for the string "calendar calendar-prefect" within the HTML (as this should only show up when the calendar is completed, and thus when the balloon animations get added). If this string is found, all days receive 2 stars ("**").

Before: image After: image

I've only fully completed 2022 (and partially 2021), so I'm not able to check if this bug applies to other years. I tested as much as I could, but apologies if I missed something!

scarvalhojr commented 11 months ago

Thanks for your contribution! Any chance you could share the raw HTML you get from your 2022 calendar so I can see why the start isn't showing? You could download it with curl, e.g.:

curl -v https://adventofcode.com/2022 -H "Content-Type: text/html" -b "session=$(cat ~/.adventofcode.session)" -o 2022-calendar.htm
WillLillis commented 11 months ago

Thanks for your contribution! Any chance you could share the raw HTML you get from your 2022 calendar so I can see why the start isn't showing? You could download it with curl, e.g.:

Thanks so much for the feedback! Here you go :) 2022-calendar.txt

(Github wouldn't let me upload it as a .html file, so I changed the extension to .txt)

scarvalhojr commented 11 months ago

Thanks so much for the feedback! Here you go :) 2022-calendar.txt

I see what's happening now. The original code assumes every day comes in a single line but obviously that's not the case for 2022.

I'll merge your change as a temporary fix. Thanks!