search

scawful / Oracle-of-Secrets

Custom Code for the Legend of Zelda: Oracle of Secrets ROM hack
11 stars 0 forks source link

Crash after defeating any boss, no heart container drop #39

Closed scawful closed 7 months ago

scawful commented 7 months ago

For patch v0.105-v0.106

scawful commented 7 months ago

Issue has been identified as originating from the Lanmolas expanded code. Root cause still unknown. Game gets stuck while attempting to load the song bank and crashes when picking up heart piece.

scawful commented 7 months ago

Issue seems to go deeper than simply Lanmolas code. After removing Lanmolas code, the player can pick up the heart but will get stuck when the crystal is picked up. More investigation needed.

EDIT: This was a dungeon properties issue.

Screenshot 2024-01-15 at 12 36 38 PM
scawful commented 7 months ago

Root cause was the routine Ancilla_SpawnFallingPrize which was located in the Lanmola sprite code space. Lookup on routine returned only two references so here is a quick fix.

Insides Lanmolas_Expanded.asm

org $01C742
  JSL Ancilla_SpawnFallingPrize

org $06FA34
  JSL Ancilla_SpawnFallingPrize

org $098BC1
  AncillaAdd_FallingPrize:

pullpc

Ancilla_SpawnFallingPrize:
#_05A51D: PHX
#_05A51E: TAX

#_05A51F: LDY.b #$04
#_05A521: LDA.b #$29 ; ANCILLA 29
#_05A523: JSL AncillaAdd_FallingPrize

#_05A527: PLX

#_05A528: RTL