Updated version

[ArnoldSmith86]

Hey! Not sure if my comments triggered your activity yesterday. Either way, it looks like a good idea to simply trigger for any controller.

I was actually working on the script today as well (before seeing your update). It still uses the whitelist but adds new devices to it automatically. Compared to your new version, I like the logging of mine and the fact that the bus IDs are no longer hard coded (the USB device IDs are, though).

Pick whatever you want from my version. Also feel free to close this issue.

Also letting you know that @TacticalLaptopBag wrapped a Decky plugin around this (that still needs some work): decky-controller-dock. There's a discussion on Discord about it: https://discord.com/channels/960281551428522045/1197141225967468615 (Decky Loader Discord)

The human readable logging and auto-adding of new devices was intended to let the Decky plugin show it in the UI and create checkboxes for each entry in the whitelist.

# /etc/udev/rules.d/
KERNEL=="input*", SUBSYSTEM=="input", ACTION=="add", RUN+="/home/deck/.local/share/scawp/SDADSC/disable_steam_input.sh disable %E{NAME} %E{PRODUCT}"
KERNEL=="input*", SUBSYSTEM=="input", ACTION=="remove", RUN+="/home/deck/.local/share/scawp/SDADSC/disable_steam_input.sh enable %E{NAME} %E{PRODUCT}"

#!/bin/bash
#Steam Deck Auto Disable Steam Controller by scawp
#License: DBAD: https://github.com/scawp/Steam-Deck.Auto-Disable-Steam-Controller/blob/main/LICENSE.md
#Source: https://github.com/scawp/Steam-Deck.Auto-Disable-Steam-Controller
# Use at own Risk!

set -e

script_install_dir="/home/deck/.local/share/scawp/SDADSC"
conf_dir="$script_install_dir/conf"
tmp_dir="/tmp/scawp/SDADSC"

mkdir -p "$tmp_dir" "$conf_dir"

debug=0
action="$1"
device_name=$(sed 's/[.[\*^$]/_/g' <<<"$2")

if [ "$3" = "3/28de/11ff/1" ] || [ "$3" = "3/28de/1205/111" ]; then
  #Steam converts all inputs to virtual 360 pads with id 3/28de/11ff/1 (I hope!) and its own inputs have id 3/28de/1205/111, ignore.
  [ "$debug" = 1 ] && echo "$(date +'%F %T') - $1 - $2 ($device_name) - $3 --- IGNORING" >> "$script_install_dir/debug.log"
  exit 0
else
  [ "$debug" = 1 ] && echo "$(date +'%F %T') - $1 - $2 ($device_name) - $3" >> "$script_install_dir/debug.log"
fi

if [ ! -f "$conf_dir/disabled" ]; then
  if [ "$action" = "disable" ] && grep -q "^$device_name$" "$conf_dir/simple_device_list.txt"; then
    if [ ! -f "$tmp_dir/controller_id.txt" ]; then
      echo "$(date +'%F %T') - Disabling internal controller because '$device_name' was connected." >> "$script_install_dir/action.log"
      echo /sys/bus/usb/drivers/usbhid/*/0003:28DE:1205.* | grep -Po '[0-9]+-[0-9]+:[0-9]+.[0-9]+' | sort -u | tee "$tmp_dir/unbound_ids.txt" | while read LINE; do
        echo $LINE > /sys/bus/usb/drivers/usbhid/unbind
      done
    else
      echo "$(date +'%F %T') - '$device_name' was connected but internal controller is already disabled. Adding to wait list." >> "$script_install_dir/action.log"
    fi
    echo "$device_name" >> "$tmp_dir/controller_id.txt"

  elif [ "$action" = "enable" ] && [ -f "$tmp_dir/controller_id.txt" ] && grep -qi "^$device_name$" "$tmp_dir/controller_id.txt"; then
    sed -i "0,/^$device_name$/{//d}" "$tmp_dir/controller_id.txt"

    if [ ! -s "$tmp_dir/controller_id.txt" ]; then
      echo "$(date +'%F %T') - Enabling internal controller because '$device_name' was disconnected." >> "$script_install_dir/action.log"
      while read LINE; do
        echo $LINE > /sys/bus/usb/drivers/usbhid/bind
      done <"$tmp_dir/unbound_ids.txt"
      rm "$tmp_dir/controller_id.txt" "$tmp_dir/unbound_ids.txt"
    else
      echo "$(date +'%F %T') - '$device_name' was disconnected but internal controller is kept disabled because other controllers are still connected. Removing from wait list." >> "$script_install_dir/action.log"
    fi
  elif [ "$action" = "enable" ] && ! grep -q "^#\\?$device_name$" "$conf_dir/simple_device_list.txt"; then
    echo "#$device_name" >> "$conf_dir/simple_device_list.txt"
    LANG=en_US.UTF-8 sort -o "$conf_dir/simple_device_list.txt" "$conf_dir/simple_device_list.txt"
    echo "$(date +'%F %T') - '$device_name' was connected for the first time and added to '$conf_dir/simple_device_list.txt'. Remove the prefixed '#' to enable the script for it." >> "$script_install_dir/action.log"
  fi
fi

[MisterFloppy]

I would like to try your modified script, could you please adapt it to work on Steam Deck with Steam OS 3.5.17, too?

[ArnoldSmith86]

What is the problem? And what do the logs say if you set debug=1?

[MisterFloppy]

Problem is that with the original script by scawp Steam Deck input doesn't work at all after installing under Steam OS 3.5.17.. Previous version of the script worked fine, the new one however disables my steam decks input completely without any external devices being connected - see the other thread: https://github.com/scawp/Steam-Deck.Auto-Disable-Steam-Controller/issues/11

Like other users I reported the issue there, but since today we didn't get any response from scawp. Then I saw that you modified the script and was hoping that your version didn't have this issue under Steam OS 3.5.17.

To be honest, I'm coming from Windows and am a Noob regarding Linux, so I might didn't do it the correct way. I followed scawps instructions on https://github.com/scawp/Steam-Deck.Auto-Disable-Steam-Controller and just replaced the content of disable_steam_input.sh with the the code you mentioned above. But it didn't work either, probably I did it the wrong way.

Maybe you can tell me the correct way step-by-step to get your script working, please? Can you confirm that your script is compatible with Steam OS 3.5.17?

[scawp]

I'm running 3.5.17 and all is fine for me, I would suspect the issue is due to differnet hardware from different revisions of the Deck. The code ignores the Steam Decks own controller with ID of 3/28de/1205/111 but its possible this isn't the same for everyone.

if you could provide the debug log found in /tmp/scawp/SDADSC/debug.log or just the row that says the ID.

eg for me

enable - input36 - Steam Deck - FXAA20103942 - 3/28de/1205/111

[MisterFloppy]

Thank you for the response, scawp!

My Steam Decks own controller ID is different: 3/28de/1205/110

Here's an example line of my debug.log file: disable - input166 - Steam Deck - FVAA23202316 - 3/28de/1205/110

[scawp]

@MisterFloppy I've updated the script, please reinstall and let me know if this has resolved your issue

[MisterFloppy]

You are brilliant - everything is working perfect now!

Thank you very, very much!

[jsnipper80]

You are brilliant - everything is working perfect now!

Thank you very, very much!

Was the issue that you had an OLED Steam Deck? Or just a different hardware version?

[MisterFloppy]

A different hardware version.