search

scawp / Steam-Deck.Shader-Cache-Killer

Script to Purge The Steam Decks Shader Cache
Other
437 stars 11 forks source link

Installer does not need sudo #16

Open rgreening opened 1 year ago

rgreening commented 1 year ago

Not sure why, but you have used sudo in the installer and it is not required. As you are the user executing the installer and not using privs other than the default user, this actually poses a security risk to run this script with unnecessary elevated privs.

rgreening commented 1 year ago

Just to add: i have downloaded the installer and modified it to remove all sudo references and it executes as expected and installs the scripts correctly. Please consider updating the installer to remove the requirement for sudo and the user having to set a root/admin password when not required. One less step for users to perform.

dacid44 commented 1 year ago

Yes, please remove the sudo. Even after verifying that the script isn't doing anything malicious, it's extremely unnerving being asked for a sudo password for something that should only be installing to the home folder.

introkun commented 2 months ago

I've updated the installer to go with the normal user in my fork https://github.com/introkun/Steam-Deck.Shader-Cache-Killer since @scawp is not supporting the repo.