search

sccn / EEG-BIDS

21 stars 17 forks source link

pop_bidsimport default options #138

Closed arnodelorme closed 3 months ago

arnodelorme commented 2 years ago

If there is no channel file, there is a crash. Is the channel file required?

If there is no event file, there is a crash. The 'bidsevents' option is on by default, but if there is no event, it should not cause the function to crash by default. Pull changes, then to test

eeglabp = fileparts(which('eeglab'));
[TMP,TMP2] = pop_importbids( fullfile(eeglabp, 'sample_data', 'test_data', 'BIDS_test') );
dungscout96 commented 2 years ago

channels.tsv is not required but events.tsv is. We can change bidschanloc to off by default. The plugin imports fine with bidsevents off and there's no events.tsv if users want to do it that way.

arnodelorme commented 2 years ago

I think we want to have bidsevents on by default but not crash when there are no events.

On Aug 5, 2022, at 10:47 AM, Dung Truong @.***> wrote:

channels.tsv is not required but events.tsv is. We can change bidschanloc to off by default. The plugin imports fine with bidsevents off and there's no events.tsv if users want to do it that way.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

dungscout96 commented 3 months ago

This is now handled