search

sccn / EEG-BIDS

21 stars 17 forks source link

Importing motion-bids data through bids-matlab tools #146

Closed sjeung closed 3 months ago

sjeung commented 2 years ago

Hello Arno,

I hope you are doing well, as discussed some time ago, I would like to hear out what you think of importing Motion data together with EEG.

Here is the MoBI-version of your script that I have modified to also import motion data in BIDS format into eeglab. For us to synchronize EEG and motion data for further processing it is very convenient to import it together with EEG and have it saved as .set format.

The question is, whether you deem it proper to reflect this change to official bids-matlab-tools script. If that is the case, I will refactor this and submit a proper pull request. Otherwise, it is also an option to keep the diverged copy of the script within the BeMoBIL pipeline.

Please let me know what you prefer, thanks!

Best, Sein

arnodelorme commented 1 year ago

Wonderful.

Here is the MoBI-version of your script that I have modified to also import motion data in BIDS format into eeglab. For us to synchronize EEG and motion data for further processing it is very convenient to import it together with EEG and have it saved as .set format.

The question is, whether you deem it proper to reflect this change to official bids-matlab-tools script. If that is the case, I will refactor this and submit a proper pull request.

Yes, please, although is it an official BIDS format. If it is let’s do it. Otherwise, we should put warning in the code that this is not official format.

Otherwise, it is also an option to keep the diverged copy of the script within the BeMoBIL pipeline.

Let’s not keep diverging copies.

Cheers,

Arno

dungscout96 commented 3 months ago

bids-motion import is now supported