search

sccn / EEG-BIDS

21 stars 17 forks source link

motion capture issue (ds003846) #192

Closed arnodelorme closed 5 months ago

arnodelorme commented 10 months ago

Dataset ds003846 has motion data and cannot be imported. The issue is that the JSON file is not present.

https://nemar.org/dataexplorer/detail?dataset_id=ds003846

arnodelorme commented 10 months ago
Screen Shot 2023-11-28 at 2 10 13 PM
sjeung commented 10 months ago

Probably both the data set and import tool need to be brought up-to-date with the current motion spec. I will submit the importer update before I go off on end of the year holiday.

arnodelorme commented 10 months ago

Thanks Sein

On Wed, Nov 29, 2023 at 3:51 AM Sein Jeung @.***> wrote:

Probably both the data set and import tool need to be brought up-to-date with the current motion spec. I will submit the importer update before I go off on end of the year holiday.

— Reply to this email directly, view it on GitHub https://github.com/sccn/bids-matlab-tools/issues/192#issuecomment-1831748389, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOJGQIQWBPGGDKC2NOQ4KLYG4OTPAVCNFSM6AAAAAA76O2USKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZRG42DQMZYHE . You are receiving this because you authored the thread.Message ID: @.***>

arnodelorme commented 7 months ago

Hi @sjeung happy new year! Any update? Tx

sjeung commented 7 months ago

Hi @sjeung happy new year! Any update? Tx

Hello, happy new year to you, too! No matter which new year we follow I'm behind the schedule with this one. I will get to this now.

arnodelorme commented 7 months ago

Thanks, let us know when there is progress.

sjeung commented 7 months ago

Ok, this particular error seems to arise from nonadherence of the data set to the current motion spec. The .json accompanying motion.tsv should have a name matching the tsv file,

'sub-1_ses-TestEMS_task-PredError_tracksys-HTCVive_motion.json' for 'sub-1_ses-TestEMS_task-PredError_tracksys-HTCVive_motion.tsv'

In the current data set, the metadata file is named 'sub-1_ses-TestEMS_task-PredError_motion.json'.

I will

  1. also check if a data set using up-to-date Motion BIDS can be imported using pop_importbids function, and submit needed changes to pop_importbids
  2. and ping the owner of the repo to bring the data set up-to-date
sjeung commented 7 months ago

I tested bids matlab tools with a different data set and opened this pull request. #199 Other than that it seems to work well

lukasgehrke commented 7 months ago

Hey @sjeung @arnodelorme, the dataset with accession number ds003846 has been updated on openneuro (https://openneuro.org/datasets/ds003846/versions/2.0.0). It should conform to the latest BIDS motion spec and pop_importbids works using @sjeung https://github.com/sjeung/bids-matlab-tools motion-bids branch as it needs to loop over multiple motion tracksys.

arnodelorme commented 6 months ago

OK, is it possible to issue a pull request on the main repo. The motion capture capabilities are beta, and so we can merge them in master. It is too complex for our research assistant to test a remote branch. CC @lukasgehrke @sjeung

sjeung commented 6 months ago

Hi Arno, I believe PR #199 deals with this. Thanks for merging!

arnodelorme commented 6 months ago

Ah OK, thanks. @asalazar4 would you mind to try this dataset again?

dungscout96 commented 5 months ago

Trying to import this dataset lead to a suggestion to the BIDS motion spec: https://github.com/bids-standard/bids-specification/pull/1817 We also detected an issue of motion.json not containing the required SamplingFrequency field, which we are currently ignoring for now. We have updated error message for this dataset on NEMAR however.