search

sccn / EEG-BIDS

23 stars 17 forks source link

Dataset editing vs group editing #20

Closed arnodelorme closed 4 years ago

arnodelorme commented 4 years ago
Screen Shot 2020-08-20 at 1 59 16 PM

@dungscout96 when editing a study and then going to edit a single dataset, the BIDS function return this warning. Pressing the YES button creates an error.

dungscout96 commented 4 years ago

I'm unable to reproduce the error. Can you describe more specifically what steps you took @arnodelorme?

arnodelorme commented 4 years ago

Thanks @dungscout96 . First edit at the group level and add gender for example for each person. Then go to the dataset level and try editing a single participant. Note that I did some changes in eegplugin_bids-matlab-tools which might have fixed the issue.

dungscout96 commented 4 years ago

Do you clear STUDY first, then load a single dataset to edit, or do you keep the STUDY loaded, then use the command line to edit a single dataset indexing the EEG struct?

arnodelorme commented 4 years ago

Yes, it was a new study just created.

Arno

On Aug 22, 2020, at 12:26 PM, Dung Truong notifications@github.com wrote:

Did you clear STUDY first, then load a single dataset to edit, or do you keep the STUDY loaded, then use the command line to edit a single dataset indexing the EEG struct?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

dungscout96 commented 4 years ago

I tried loading a new study (EEGLAB example study), edit gender information for all subjects, clear study, load single dataset, edit gender info and received no error. I reloaded the study again after editing the single set and also didn't receive the reported error. The issue might have been fixed then.

Closing it for now and we can reopen if the issue reappear.

arnodelorme commented 4 years ago

Thanks Dung. Yes, I will continue testing. I have released a version yesterday (which include some of your changes last week) because of other changes I did.

Cheers,

Arno

On Tue, Aug 25, 2020 at 7:32 AM Dung Truong notifications@github.com wrote:

Closed #20 https://github.com/sccn/bids-matlab-tools/issues/20.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sccn/bids-matlab-tools/issues/20#event-3691201707, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOJGQOJTXWHNO4JL26BWFLSCPYTHANCNFSM4QGWY5RQ .