search

sccn / EEG-BIDS

23 stars 17 forks source link

Electrode types #64

Closed arnodelorme closed 3 years ago

arnodelorme commented 3 years ago

Clement to edit default electrode file .elc for BEM model to .ced to add channel type.

cll008 commented 3 years ago

Just tested things out with CED. We only care about channel label, x, y, z, and type for the BEM template. Two options:

  1. Turn 'blankcells' back on when reading the text file so that format is preserved
  2. Fill theta, sph* etc. columns with nans and add lines to ignore nans when writing to chanlocs structure

1 is more intuitive to me but can't be used if 'blankcells' is 'off' for a specific reason.

File wise, I'm thinking of naming it standard-1005_BIDS.ced and adding it to the BEM folder. Sound good?

arnodelorme commented 3 years ago

We should slightly modify the CED format so empty columns are allowed.

On Mar 16, 2021, at 8:20 AM, Clement Lee @.***> wrote:

Just tested things out with CED. We only care about channel label, x, y, z, and type for the BEM template. Two options:

• Turn 'blankcells' back on when reading the text file so that format is preserved • Fill theta, sph* etc. columns with nans and add lines to ignore nans when writing to chanlocs structure 1 is more intuitive to me but can't be used if 'blankcells' is 'off' for a specific reason.

File wise, I'm thinking of naming it standard-1005_BIDS.ced and adding it to the BEM folder. Sound good?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

cll008 commented 3 years ago

Well, CED allows empty columns and cells, the CED file itself doesn't become corrupted or anything. I linked to the line in readlocs above, where 'blankcells' are not allowed. We can change this and things would work, but I don't know what it would break / why that is there to begin with: under what circumstances would a CED file have blank cells that should be ignored?

arnodelorme commented 3 years ago

Yes, we should fix readlocs to accept empty columns for CED. It is not a big deal because this CED file will always be released with a version of readlocs that supports it. As backup, we could save an SFP file with spherical coordinates though.

On Mar 16, 2021, at 10:30 AM, Clement Lee @.***> wrote:

I linked to the line in readlocs above, where 'blankcells' are not allowed. We can change this and things would work, but I don't know what it would break / why that is there to begin with: under what circumstances would a CED file have blank cells that should be ignored?