search

sccn / EEG-BIDS

21 stars 17 forks source link

GUI update: reformat char to string for tInfo and gInfo #97

Closed cll008 closed 2 years ago

cll008 commented 2 years ago

Thankfully because of dynamic field tags I only had to use reformatchartostring twice (once for gInfo, once for tInfo). Not sure if it would be more readable to shift more lines to the subfunction.

fix #95. also add .txt extension to README. tested to work with p300 dataset.

cll008 commented 2 years ago

@arnodelorme I think we got distracted on Monday and didn't discuss this but this fixes the readme problem.

arnodelorme commented 2 years ago

Are you sure the README file should be "README.txt" Can you check the BIDS specifications?

cll008 commented 2 years ago

"In addition a free form text file (README) describing the dataset in more details SHOULD be provided. The README file MUST be either in ASCII or UTF-8 encoding."

Does "free form" mean no file extensions?...

arnodelorme commented 2 years ago

It does say “README” not “README.txt” Free form is for the content of the file. I am not sure README.txt will pass the validator.

Arno

On Nov 3, 2021, at 11:00 AM, Clement Lee @.***> wrote:

"In addition a free form text file (README) describing the dataset in more details SHOULD be provided. The README file MUST be either in ASCII or UTF-8 encoding."

Does "free form" mean no file extensions?...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

cll008 commented 2 years ago

Confirmed that .txt does not pass BIDS validator. Removed that change.