sccn / ICLabel

Automatic EEG IC classification plugin for EEGLAB
https://iclabel.ucsd.edu/tutorial
53 stars 19 forks source link

matconvnet DagNN incompatible with MATLAB versions prior to R2012a #1

Closed lucapton closed 5 years ago

lucapton commented 5 years ago

Incompatabilites found so far are:

  1. Object property "access" can only be "public", "protected", or "private" but some DagNN methods pass meta-classes which is only supported starting with R2012a.

    • This might be fixed by changing the meta-class accesses to public.
  2. DagNN inherits from matlab.mixin.Copyable which was added in R2011a.

    • This might be fixed by including code to replace the Copyable class. Ideas here.

For now ICLabel is constrained to support only MATLAB R2012a and newer.

lucapton commented 5 years ago

Fixed in commit 6a2f231b63502438ce99f4e02bb851f2e5b10611