search

sccn / ICLabel

Automatic EEG IC classification plugin for EEGLAB
https://iclabel.ucsd.edu/tutorial
53 stars 19 forks source link

Octave compatibility #2

Closed arnodelorme closed 5 years ago

arnodelorme commented 5 years ago

I have changed a couple of functions to make it compatible with Octave. It requires to pull the latest changes from EEGLAB develop branch.

lucapton commented 5 years ago

I get an error when running the replacement for resample in eeg_autocorr_welch.m

Error using chckxy (line 89)
The number of sites, 129, is incompatible with the number of values, 32.

Error in spline (line 54)
[x,y,sizey,endslopes] = chckxy(x,y);

Error in eeg_autocorr_welch>myresample (line 92)
cs = spline( X, data);

This seems to be due to the widths of X and data not matching in the call to spline but transposing data fixes it. 

cs = spline( X, data');

As I don't have easy access to octave, could you check if that is a viable fix for octave as well? I can integrate the change if so. If you get the chance, you could also run run_tests.m in octave which will check many common issues and see if anything else fails.

lucapton commented 5 years ago

I botched this pull request. I was trying to commit a change to your fork but I misread the instructions and pushed it to my own master branch. I've reverted the changed but this pull request is now closed and I don't know how to reopen it. That may be okay as I still have the changes on a local branch. Once we figure out the issue in my last comment I can make the changes locally and merge them into master myself. I should be able to reference this pull request in that commit for historical consistency.