search

sccn / ICLabel

Automatic EEG IC classification plugin for EEGLAB
https://iclabel.ucsd.edu/tutorial
53 stars 19 forks source link

Labels remain after components are removed #8

Closed JohnAtl closed 4 years ago

JohnAtl commented 4 years ago

When components are removed, labels remain and are invalid. The labels still reflect the values of the prior component numbers.

Screen Shot 2020-05-14 at 11 07 47 AM
lucapton commented 4 years ago

Thanks for pointing this out. I've thought about the issue before but didn't have a good solution. Now that I consider it again, perhaps label validity could be checked against a hash of EEG.icawinv. What you do you think about that @arnodelorme?

arnodelorme commented 4 years ago

I think pop_runica should remove labels when components are removed. I have modified pop_runica.

Arno

JohnAtl commented 4 years ago

If one uses iclabel() then pop_icflag(), then pop_subcomp() to remove the bad components, then looks at the components using pop_viewprops(), the labels left behind are misleading. Ideally, pop_subcomp() would remove the labels of components that are removed, or if that isn't practical, remove all labels.

Regards, John

arnodelorme commented 4 years ago

Yes, pop_subcomp() needs to be updated to remove the components as well. I have updated it and changed the zip file.