search

sccn / amica

Code for AMICA: Adaptive Mixture ICA with shared components
BSD 2-Clause "Simplified" License
23 stars 13 forks source link

EEGLAB doesn't recognize EEG structure change after AMICA #18

Open arnodelorme opened 4 years ago

arnodelorme commented 4 years ago

I'm using the AMICA plugin for my decomposition, and after training is done and I use 'load AMICA components' I'd like to use File-->Save current dataset(s) to save the dataset with the weights in it. If I try that, I get a 'Dataset has not been modified; No need to resave it' message; I have to save the dataset as a completely new file instead.

I'd like to force EEGLAB to recognize the change so I can resave the file without having to create a new one.

Marissa

arnodelorme commented 4 years ago

This can be fixed by adding

EEG.saved = 'no';

at the end of pop_amica.m

japalmer29 commented 4 years ago

Arno, are you able to commit changes? I am ok with any eeglab interface fixes.

Thanks,

Jason

From: Arnaud Delorme notifications@github.com Sent: Wednesday, November 27, 2019 10:47 PM To: japalmer29/amica amica@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [japalmer29/amica] EEGLAB doesn't recognize EEG structure change after AMICA (#18)

This can be fixed by adding

EEG.saved = 'no';

at the end of pop_amica.m

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/japalmer29/amica/issues/18?email_source=notifications&email_token=ACRBESWXFWW23NYO37KV5W3QVZ25NA5CNFSM4JSHBDJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFJRSOA#issuecomment-559094072 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACRBESTRPWWF3ZLCSVTFAELQVZ25NANCNFSM4JSHBDJQ . https://github.com/notifications/beacon/ACRBESQMV4UAKLJZJUM3HLDQVZ25NA5CNFSM4JSHBDJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFJRSOA.gif

arnodelorme commented 4 years ago

I am unsure of where to commit the changes or I would have done it already.

japalmer29 commented 4 years ago

I thought you were made an owner of the amica github at japalmer29/amica before, and that this was an issue because that’s where eeglab gets amica functions from.

From: Arnaud Delorme notifications@github.com Sent: Thursday, November 28, 2019 11:13 AM To: japalmer29/amica amica@noreply.github.com Cc: Jason Palmer japalmer29@gmail.com; Comment comment@noreply.github.com Subject: Re: [japalmer29/amica] EEGLAB doesn't recognize EEG structure change after AMICA (#18)

I am unsure of where to commit the changes or I would have done it already.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/japalmer29/amica/issues/18?email_source=notifications&email_token=ACRBESWRX7ALGWC7SXZWKSTQV4SMDA5CNFSM4JSHBDJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFLHBBI#issuecomment-559313029 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACRBESX43NW54RLXDI5VYNLQV4SMDANCNFSM4JSHBDJQ . https://github.com/notifications/beacon/ACRBESSBREESOYKWCDDBBLLQV4SMDA5CNFSM4JSHBDJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFLHBBI.gif