sccn / amica

Code for AMICA: Adaptive Mixture ICA with shared components
BSD 2-Clause "Simplified" License
24 stars 15 forks source link

When AMICA information is in the data, epoching does not work in EEGLAB unless plugin is loaded #19

Open arnodelorme opened 5 years ago

arnodelorme commented 5 years ago

Jeff Schmitz 2011-10-31 11:53:33 PDT Then likely we should add eeg_formatamica() to the general release since AMICA is here to stay and should in due course become the new default ICA ... (from Scott in an email) [reply] [−]Comment 2Arnaud Delorme 2011-10-27 15:12:32 PDT I am now assigning this bug to Ozgur.

Arno [reply] [−]Comment 1Jeff Schmitz 2011-10-27 10:35:59 PDT Hi Clemens,

Could you attach the data set with AMICA information? It will help me reproduce the bug for testing.

Thanks,

Jeff [reply] [−]DescriptionClemens Brunner 2011-10-27 10:23:04 PDT For data sets with AMICA information, epoching does not work unless the AMICA plugin is loaded. This is not very convenient; IMO, AMICA information should not have an influence on default EEGLAB functionality.

Specifically, I get the following error in line 240 of pop_epoch(): Undefined function 'eeg_formatamica()' for input arguments of type 'struct'.

Again, this only happens when the AMICA plugin is not loaded.

arnodelorme commented 5 years ago

We should at least have a warning message.

japalmer29 commented 5 years ago

I am not sure what this error is. Where is eeg_formatamica()? I don’t see it in eegpluglin_amica or pop_runamica. Is this still an issue?

From: Arnaud Delorme notifications@github.com Sent: Thursday, November 28, 2019 6:51 AM To: japalmer29/amica amica@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [japalmer29/amica] When AMICA information is in the data, epoching does not work unless plugin is loaded (#19)

Jeff Schmitz 2011-10-31 11:53:33 PDT Then likely we should add eeg_formatamica() to the general release since AMICA is here to stay and should in due course become the new default ICA ... (from Scott in an email) [reply] [−]Comment 2Arnaud Delorme 2011-10-27 15:12:32 PDT I am now assigning this bug to Ozgur.

Arno [reply] [−]Comment 1Jeff Schmitz 2011-10-27 10:35:59 PDT Hi Clemens,

Could you attach the data set with AMICA information? It will help me reproduce the bug for testing.

Thanks,

Jeff [reply] [−]DescriptionClemens Brunner 2011-10-27 10:23:04 PDT For data sets with AMICA information, epoching does not work unless the AMICA plugin is loaded. This is not very convenient; IMO, AMICA information should not have an influence on default EEGLAB functionality.

Specifically, I get the following error in line 240 of pop_epoch(): Undefined function 'eeg_formatamica()' for input arguments of type 'struct'.

Again, this only happens when the AMICA plugin is not loaded.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/japalmer29/amica/issues/19?email_source=notifications&email_token=ACRBESXQQZYGRFGPBMEAEMDQV3TUPA5CNFSM4JSMTKB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H4Q34IQ , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACRBESUEBJT6KI5SDUMJNT3QV3TUPANCNFSM4JSMTKBQ . https://github.com/notifications/beacon/ACRBESWBBH6SFVTQKI76N5TQV3TUPA5CNFSM4JSMTKB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H4Q34IQ.gif