search

sccn / amica

Code for AMICA: Adaptive Mixture ICA with shared components
BSD 2-Clause "Simplified" License
23 stars 13 forks source link

created a seperate subroutine for writing history #41

Closed jfrank8 closed 1 year ago

jfrank8 commented 1 year ago

Previously, writing history was part of the write_output subroutine. So every time the number of iterations mod write output was called there'd be a check if the number of iterations mod histstep was zero. So in the case that writeoutput wasn't a multiple of histstep in the parameters file the history wouldn't get recorded. I just made recording the history it into a separate subroutine so the history is always recorded and the files are correctly made regardless what the relationship between writeoutput and histstep is.

japalmer29 commented 1 year ago

Thank you very much! I knew there was a bug in write history never got around to fixing it.

Jason

From: Gwenevere Frank @.> Sent: Friday, June 2, 2023 5:24 PM To: sccn/amica @.> Cc: Subscribed @.***> Subject: [sccn/amica] created a seperate subroutine for writing history (PR #41)

Previously, writing history was part of the write_output subroutine. So every time the number of iterations mod write output was called there'd be a check if the number of iterations mod histstep was zero. So in the case that writeoutput wasn't a multiple of histstep in the parameters file the history wouldn't get recorded. I just made recording the history it into a separate subroutine so the history is always recorded and the files are correctly made regardless what the relationship between writeoutput and histstep is.

You can view, comment on, or merge this pull request online at:

https://github.com/sccn/amica/pull/41

Commit Summary

File Changes

(1 https://github.com/sccn/amica/pull/41/files file)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/sccn/amica/pull/41 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACRBESRZ73CE4QSRRLKN6PDXJJKYXANCNFSM6AAAAAAYYZ5Z3I . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/ACRBESTS2PMB52PRKGXQS3LXJJKYXA5CNFSM6AAAAAAYYZ5Z3KWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHGPJE5YI.gif Message ID: @. @.> >