search

sccn / bva-io

Routines for loading and saving data files in Brain Vision Data Exchange format (export and import of Brain Vision Analyzer MATLAB files developed by Arnaud Delorme)
23 stars 11 forks source link

Add copy function and update import and export functions #1

Closed jdkoen closed 5 years ago

jdkoen commented 5 years ago

I updated some code to handle parsing the channel information (specifically units) and reading in all of the .vhdr and .vmrk files into a cell array in EEG.etc.bv_vhdr_file and EEG.etc.bv_vmrk_file, respectively. These can be used to modify write functions (in the future) to copy directly information from these files. This will help keep up with formatting these files should anything change with Brain Vision.

I have also added some utility functions (bv_event_string and bv_text_catcher) to get at things that appeared multiple times in the load/write functions.

I also added functions to copy (and rename) a brain vision dataset (.vhdr, .eeg, and .vmrk) files. This is pop_copybv(). If using scripting, this can also specify a loaded EEG dataset to copy the event markers from (except for boundaries and new segments).

I also added a 'new' pop_writebva function (pop_writebva2) that simply uses the code and type files to write markers without the relabeling present in pop_writebva.

widmann commented 5 years ago

Why did you close the issue?

jdkoen commented 5 years ago

One of the changes I made resulted in pop_loadbv() not scaling the data on import. I was going to try and figure that out really quick and resubmit the pull request. Sorry about that.

Thanks,

Josh

On Wed, Jun 19, 2019 at 6:22 AM widmann notifications@github.com wrote:

Why did you close the issue?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/widmann/bva-io/pull/1?email_source=notifications&email_token=AAXXPVDMYHWSYHNOR5OIVADP3ICHZA5CNFSM4HTLOKNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYBNGNA#issuecomment-503501620, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXXPVE5ZN44QPIO6F4MW53P3ICHZANCNFSM4HTLOKNA .

widmann commented 5 years ago

Ah, ok. If possible I would prefer separate pull requests for the different enhancements. This would make code review considerably easier and I could ask Arno to check the enhancements for the writing functions (he maintains) separately. Thanks!

jdkoen commented 5 years ago

Sounds good. I will make sure to do that moving forward

On Wed, Jun 19, 2019 at 7:18 AM widmann notifications@github.com wrote:

Ah, ok. If possible I would prefer separate pull requests for the different enhancements. This would make code review considerably easier and I could ask Arno to check the enhancements for the writing functions (he maintains) separately. Thanks!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/widmann/bva-io/pull/1?email_source=notifications&email_token=AAXXPVHKMEUIAHUCVQ67E63P3IIZFA5CNFSM4HTLOKNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYBRIGY#issuecomment-503518235, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXXPVGWOBLKMN767HM7YADP3IIZFANCNFSM4HTLOKNA .