search

sccn / bva-io

Routines for loading and saving data files in Brain Vision Data Exchange format (export and import of Brain Vision Analyzer MATLAB files developed by Arnaud Delorme)
23 stars 11 forks source link

Add function to copy BV file sets and update vhdr and vmrk files appropriately #2

Closed jdkoen closed 5 years ago

jdkoen commented 5 years ago

Creates functionality to copy and rename brain vision file sets. pop_copybv() updates the DataFile and MarkerFile information in the .vhdr and .vmrk files. bv_text_catcher() is a utility function to capture the DataFile and MarkerFile strings, and then update them with the new information.

widmann commented 5 years ago

Thanks for the contribution! The "usage" and "input" parts of the help text of bv_text_catcher.m are incorrect and misleading. Could you please correct? Or preferably, in case the bv_text_catcher function will not also be used in other plugin functions in foreseeable future, make it a nested function within pop_copybv? And add trailing newline at the ends of the files?

Thank you! Best, Andreas

jdkoen commented 5 years ago

Thank you for the feedback. I made the requested changes (bv_text_catcher as a nested function in pop_copybv) and adding trailing newlines at the end of pop_copybv. bv_text_catcher was deleted as a stand alone file, but the help information (which I also updated) is kept with it just in case it requires moving to a stand alone function in the future.

widmann commented 5 years ago

Merged. Thanks for the contribution! Best, Andreas

jdkoen commented 5 years ago

Great news! Thanks for the help.

I have some other ideas that I hope to get too in the future (it will probably take a while). I’ll reach out to get your input on these changes when I get around to them (mainly to help me determine if they will be useful, and if you see any potential drawbacks to the approaches). What is the best way to communicate about this (GitHub or personal messages)?

Best,

Josh

On Mon, Aug 26, 2019 at 11:43 AM widmann notifications@github.com wrote:

Merged. Thanks for the contribution! Best, Andreas

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/widmann/bva-io/pull/2?email_source=notifications&email_token=AAXXPVCCP2K5HDNYSI4A5LTQGP2ZLA5CNFSM4IMRAWJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5EYOSQ#issuecomment-524912458, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXXPVHPADUKSNVAWLJTO7TQGP2ZLANCNFSM4IMRAWJQ .

widmann commented 5 years ago

What is the best way to communicate about this (GitHub or personal messages)? Typically, GitHub is the preferred platform. The development process is documented for future reference and also others can contribute their opinions. The latter might be particularly relevant in case of the writing/export functions which are maintained by Arno. And GitHub has the core advantage that issues/requests remain open until fixed/merged serving as a reminder. Emails tend to slip beyond the email event horizon...

Straight-forward short questions can be discussed by mail of course.

Best, Andreas

Am 26.08.2019 um 18:36 schrieb Josh Koen notifications@github.com:

Great news! Thanks for the help.

I have some other ideas that I hope to get too in the future (it will probably take a while). I’ll reach out to get your input on these changes when I get around to them (mainly to help me determine if they will be useful, and if you see any potential drawbacks to the approaches). What is the best way to communicate about this (GitHub or personal messages)?

Best,

Josh

On Mon, Aug 26, 2019 at 11:43 AM widmann notifications@github.com wrote:

Merged. Thanks for the contribution! Best, Andreas

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/widmann/bva-io/pull/2?email_source=notifications&email_token=AAXXPVCCP2K5HDNYSI4A5LTQGP2ZLA5CNFSM4IMRAWJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5EYOSQ#issuecomment-524912458, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXXPVHPADUKSNVAWLJTO7TQGP2ZLANCNFSM4IMRAWJQ .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

jdkoen commented 5 years ago

Thanks!

On Mon, Aug 26, 2019 at 12:55 PM widmann notifications@github.com wrote:

What is the best way to communicate about this (GitHub or personal messages)? Typically, GitHub is the preferred platform. The development process is documented for future reference and also others can contribute their opinions. The latter might be particularly relevant in case of the writing/export functions which are maintained by Arno. And GitHub has the core advantage that issues/requests remain open until fixed/merged serving as a reminder. Emails tend to slip beyond the email event horizon...

Straight-forward short questions can be discussed by mail of course.

Best, Andreas

Am 26.08.2019 um 18:36 schrieb Josh Koen notifications@github.com:

Great news! Thanks for the help.

I have some other ideas that I hope to get too in the future (it will probably take a while). I’ll reach out to get your input on these changes when I get around to them (mainly to help me determine if they will be useful, and if you see any potential drawbacks to the approaches). What is the best way to communicate about this (GitHub or personal messages)?

Best,

Josh

On Mon, Aug 26, 2019 at 11:43 AM widmann notifications@github.com wrote:

Merged. Thanks for the contribution! Best, Andreas

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/widmann/bva-io/pull/2?email_source=notifications&email_token=AAXXPVCCP2K5HDNYSI4A5LTQGP2ZLA5CNFSM4IMRAWJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5EYOSQ#issuecomment-524912458 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAXXPVHPADUKSNVAWLJTO7TQGP2ZLANCNFSM4IMRAWJQ

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/widmann/bva-io/pull/2?email_source=notifications&email_token=AAXXPVCEAEIPC4Q3Y34RCRLQGQDHZA5CNFSM4IMRAWJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5E63WI#issuecomment-524938713, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXXPVD233MPANHVPDIP7ODQGQDHZANCNFSM4IMRAWJQ .