search

sccn / clean_rawdata

Cleaning Raw EEG data
GNU General Public License v3.0
42 stars 17 forks source link

Possible mistake in clean_asr: window_len parameter does not seem to be passed down from clean_asr to asr_calibrate? #47

Closed rsomervail closed 1 year ago

rsomervail commented 1 year ago

I note that the calibration step of in clean_asr always uses the default 0.5 s window - while the window_len parameter passed by the user to clean_asr is only used for asr_process.

Is this a mistake? I don't fully understand the maths of ASR but shouldn't the thresholds be determined using windows of similar length to those used in the sliding window step of asr_process?

rsomervail commented 1 year ago

I see this has been addressed in a closed issue from 2 years ago (linked below) - oops, I should have checked first!

I leave this open for now though, because I am dealing with the specific case of ASR in sleep data, where brain signals are typically lower frequency and longer, and the window length seems more crucial for affecting the inappropriate removal of these brain signals.

https://github.com/sccn/clean_rawdata/issues/17#issuecomment-737397502

arnodelorme commented 1 year ago

Yes, I am closing this report. But feel free to open a new one if you encounter other problems.