Closed Horschig closed 1 year ago
Adding 6 lines for 1 family of products feels like you're turning this into a marketing gimmick and goes against the spirit of the list. Please revise to fit in 1 line.
Adding 6 lines for 1 family of products feels like you're turning this into a marketing gimmick and goes against the spirit of the list. Please revise to fit in 1 line.
I don't understand. We have one family (Brite), which is one line. We have 5 other products. I just adhered to what others do (e.g. NIRx also used two lines instead of one, Brain Products used three, etc). I can put it all on one line for sure, that's no problem. Should I then also change others?
NIRx is a good example because really it was the same software supporting 2 devices so I trimmed that down to one line. For the other examples of a single company having multiple entries, it's because the different entries are linking to different software using different approaches or different SDKs, often managed by different individuals.
In other words, this isn't so much a list of devices as it is a list of LSL integrations. The same devices could be listed multiple times if there were multiple independent LSL integrations for that device.
Ok, I see. I changed our additions accordingly. I also fixed an issue with the NIRx links, because it got somewhat corrupt after your latest update.
Thank you for your understanding. And thank you for fixing my mistake :)
Thanks! And, I know it sounds biased coming from someone working for a company with the first letter A, but shouldn't the list also be alphabetically sorted like all other lists in that file?
Yes! Once upon a time we were just adding things in the order we received them. Then we started prioritizing things that were maintained by the core team. Then we separated into different sub-lists which prompted some alphabetical sorting within lists. I'm happy to accept a PR with alphabetical sorting (without rearranging the sub-sections).
BTW, if you didn't already, you may want to add your products to the table at https://labstreaminglayer.org/#/
Turns out we've already done that for you just yesterday. Thanks for your patience with our process. @Horschig do you mind double checking your links in the PR though? When I paste them into the browser, several of them give a 404 (might be a URL capitalization issue).
Hi, thanks for checking. Indeed it's capitalization, it should all be lower case. (and the oxymon page was taken down apparently, sicne we're low on stock - weird choice).
I can't see any PR though, which one is it?
edit: oh, you meant this PR? I can't find any change that reorders the entries alphabetically.
Hi,
We'd like to add our devices to the list of supported NIRS devices. In fact, we support LSL for a couple of years already. Example publications:
A tutorial video can be found here: https://www.youtube.com/watch?v=qgxrcykkve0&feature=youtu.be
Blog post about syncing, which includes LSL: https://www.artinis.com/blogpost-all/2023/multimodal-fnirs-eeg-measurements-staying-in-sync
Link to our software: https://www.artinis.com/oxysoft/
If I missed any place where devices or software should be added, let me know. And if I made a mistake anywhere, please also let me know.