search

sccn / labstreaminglayer

LabStreamingLayer super repository comprising submodules for LSL and associated apps.
Other
522 stars 157 forks source link

submodules for Shimmer3 devices #91

Closed ShimmerEngineering closed 2 years ago

cboulay commented 2 years ago

I would prefer if the folder was named "Shimmer" instead of "app-shimmer", to be consistent with the other submodules.

Also, given that pulling all submodules isn't really part of the recommended workflow anymore, I think the best way to increase visibility is to make a PR against the docs here: https://github.com/sccn/labstreaminglayer/blob/master/docs/info/supported_devices.rst

You can also submit a new entry here: https://labstreaminglayer.org/#/

ShimmerEngineering commented 2 years ago

@cboulay we will close this pull request. we have created a new one https://github.com/sccn/labstreaminglayer/pull/93 based on your advice.