search

sccn / liblsl

C++ lsl library for multi-modal time-synched data transmission over the local network
Other
108 stars 63 forks source link

Add missing windows dependencies #100

Closed tobiasherzke closed 3 years ago

tobiasherzke commented 3 years ago

The suggested patch makes the dependencies of LSL on the following windows DLLs explicit: winmm.dll, mwsock.dll, ws2_32.dll.

When compiling with Visual C++, these DLLs are used as well, as you can check with cygcheck or dependency-walker:

$ cygcheck.exe ./lsl.dll # DLL extracted from https://github.com/sccn/liblsl/releases/download/v1.14.0/liblsl-1.14.0-Win_amd64.zip
C:\liblslvc\bin\lsl.dll
  C:\Windows\system32\bcrypt.dll
    C:\Windows\system32\ntdll.dll
  C:\Windows\system32\KERNEL32.dll
    C:\Windows\system32\KERNELBASE.dll
  C:\Windows\system32\WINMM.dll
    C:\Windows\system32\msvcrt.dll
  C:\Windows\system32\WS2_32.dll
    C:\Windows\system32\RPCRT4.dll
  C:\Windows\system32\MSWSOCK.dll

Your default windows toolchain is Visual C++, and Visual C++ seems to figure out these dependencies automatically.

We are using liblsl compiled with MinGW-W64, and this toolchain cannot deduce this dependency automatically. We need the dependency explicitly specified, as in this patch.

Specifiying these dependencies automatically does not harm your build with Visual C++ - it will continue to work fine.

I ask you to apply this patch to your code base so that other users who also use MinGW will be able to use your library.

tstenner commented 3 years ago

LGTM :+1:

I've merged the commit manually, as the winmm library is a dependency of liblsl, not lslboost and the second empty commit isn't needed. (FWIW, you can re-run the CI manually from the Github Actions page).