Don't build as a shared library if LSL_BUILD_STATIC is set

sccn / liblsl

C++ lsl library for multi-modal time-synched data transmission over the local network

Other

108 stars 63 forks source link

Don't build as a shared library if LSL_BUILD_STATIC is set #116

Closed tstenner closed 3 years ago

tstenner commented 3 years ago

PR for #115

cboulay commented 3 years ago

This is pretty straightforward so I don't feel the need to test more than the CI checks. It's also nice when a commit has net-negative code. I approve.

chausner commented 3 years ago

That's great! Thanks for implementing my suggestion. Any particular reason why you opted for a custom LSL_LIB_TYPE variable instead of using the existing BUILD_SHARED_LIBS which gets used by add_library automatically when no type is specified?

tstenner commented 3 years ago

It was two months ago so I don't recall everything, but I think it had to do with the special handling of the lib type that's necessary for the library info string and some export headers.