search

sccn / liblsl

C++ lsl library for multi-modal time-synched data transmission over the local network
Other
107 stars 63 forks source link

CMake reorganization #128

Closed tstenner closed 3 years ago

tstenner commented 3 years ago

The target_link_library(lsl PUBLIC lslobj) required lslobj to be listed in the exported targets and indirectly added a dependency on pugixml for the Ubuntu builds.

This PR links lslobj privately to lsl, moves some blocks so the code is easier to read and add the LSL_OPTIMIZATIONS flag to enable some more optimizations that will slow full builds down somewhat and incremental builds even more.

cboulay commented 3 years ago

Thanks for providing the link to the ASIO separate compilation - otherwise I would have been lost as to why that file is only included in the non-optimized build.

This looks good. It's all quite straightforward and the checks all pass so I'll go ahead and merge.