search

sccn / liblsl

C++ lsl library for multi-modal time-synched data transmission over the local network
Other
107 stars 63 forks source link

CMake install broken for static builds #138

Closed chausner closed 2 years ago

chausner commented 2 years ago

When setting LSL_BUILD_STATIC=ON, the CMake install command fails with:

CMake Error: install(EXPORT "LSLTargets" ...) includes target "lsl" which requires target "lslobj" that is not in any export set.
CMake Error: install(EXPORT "LSLTargets" ...) includes target "lsl" which requires target "lslboost" that is not in any export set.
CMake Error in CMakeLists.txt:
  export called with target "lsl" which requires target "lslobj" that is not
  in any export set.

CMake Error in CMakeLists.txt:
  export called with target "lsl" which requires target "lslboost" that is
  not in any export set.

Seems commit 730e13050142f7140a8b3de85b2a2b164eb1bc0e broke it.

cboulay commented 2 years ago

I don't have time to look into this at the moment. Maybe @tstenner will tomorrow. Either way, we need a little more info.

What platform? What version of cmake?

chausner commented 2 years ago
tstenner commented 2 years ago

I have identified the problem but it might take a few days to verify that my solution doesn't break anything else. I'll push a PR this or the next evening.