sccn / liblsl

C++ lsl library for multi-modal time-synched data transmission over the local network
Other
107 stars 63 forks source link

Replace Boost.Asio with plain Asio #155

Closed tstenner closed 2 years ago

tstenner commented 2 years ago

Closes #143.

cboulay commented 2 years ago

It would also be good to get @chausner to look at this.

chausner commented 2 years ago

It would also be good to get @chausner to look at this.

Don't really have an opinion on this as I am not really familiar with those libraries. At least, I can't think of any reason that would speak against this change.

tstenner commented 2 years ago

@chausner The main parts that might be relevant to you (out of all the 352833 changed lines :-) are:

Building the PR with MSVC (shared/static) didn't produce any new warnings that those flags were missing, but maybe there's something I have forgotten.

tstenner commented 2 years ago

Rebased and built successfully against the Android NDK