Closed chausner closed 2 years ago
Looks mostly good to me; getting rid of the compiler warnings so it's easier to notice when new ones pop up is a good idea.
Two minor things:
Before this change, this pragma was active when compiling with clang. I am not sure if this was on purpose and whether it has any effect on clang.
Clang accepts most of the GCC warnings and accepts #pragma GCC
(see https://clang.llvm.org/docs/UsersManual.html#controlling-diagnostics-via-pragmas ). For the future it might make sense to define NOWARN_MSVC()
, NOWARN_GCC_AND_CLANG()
and NOWARN_CLANG()
macros, but for now your suggestion is fine.
It also fixes another minor implicit conversion warning.
Looks good, the only thing I'd improve would be static_cast
, as it's more limited in scope than C style casts.
This would be ready to merge from my side or do you want me to make any more changes?
This fixes the following warning with MSVC:
Before this change, this pragma was active when compiling with clang. I am not sure if this was on purpose and whether it has any effect on clang. If yes, I can change the condition to:
It also fixes another minor implicit conversion warning.