search

sccn / liblsl

C++ lsl library for multi-modal time-synched data transmission over the local network
Other
114 stars 67 forks source link

Upgrade Catch2, use FetchContent #190

Closed cboulay closed 8 months ago

cboulay commented 1 year ago

The ubuntu 18.04 docker image has invalid certs and can't use FetchContent. @tstenner , any recommendations? Ubuntu 18.04 is past its EOL so we could drop it.

tstenner commented 1 year ago

Dropping it solves the problem nicely. With 1.16.2 out we could also upgrade the MSVC baseline and finally use C++14 or even C++17. I'll open a PR to start the discussion.

tstenner commented 1 year ago

https://github.com/sccn/labstreaminglayer/pull/112

tstenner commented 1 year ago

I have merged the C++17 PR, so after a rebase this could be merged as well.

cboulay commented 8 months ago

Catch2 V3 got merged in another PR. This PR is now obsolete.