search

sccn / liblsl

C++ lsl library for multi-modal time-synched data transmission over the local network
Other
120 stars 70 forks source link

Fix recovery issues #195

Closed tstenner closed 1 year ago

tstenner commented 1 year ago

See https://github.com/sccn/labstreaminglayer/issues/105

mgrivich commented 1 year ago

The new method inlet_connection::set_protocols has an error. It as the parameter const stream_info_impl &info, but refers to hostinfo in the method. Every hostinfo in set_protocols needs to be changed to info.

Other than that, I tested the pull request and it works.

tstenner commented 1 year ago

Thanks, fixed it.

cboulay commented 1 year ago

I didn't check that the issue is fixed because Matthew already did that. Code quality is good and CI workflows are passing. Actually, I haven't seen all the CI workflows succeed in a long time so this is good news.

I'm satisfied. Merge at your leisure.