search

sccn / liblsl

C++ lsl library for multi-modal time-synched data transmission over the local network
Other
115 stars 67 forks source link

Windows, cmake `--target package` puts package in {root}/package #63

Closed cboulay closed 4 years ago

cboulay commented 4 years ago

I realize that there have been a bunch of changes to the cmake files to help with CI builds. It's an iterative process and I'm just making a note of what's currently broken.

D:\Tools\Neurophys\labstreaminglayer\LSL\liblsl\build_win>cmake --build . --config Release -j --target package

CPack: - package: /package/liblsl-1.14.0-Win64.zip generated. CPack: - package: /package/lsltests-1.14.0-Win64.zip generated.

This ends up in my D:\package folder.

I guess we should have a more sane package directory.

tstenner commented 4 years ago

I can't reproduce this on my machine:

> rd /Q /s build & cmake -S . -B build & cmake --build build --config Release -j --target package
…
-- Git version information: master/v1.14.0b1-1-g34719d68
…
  CPack: Create package
  CPack: - package: C:/Users/stenner-t/source/labstreaminglayer/LSL/liblsl/build/lsl-1.14.0-win64.zip generated.
cboulay commented 4 years ago

My own issue is stale. I'll reopen if I encounter it again. I use a different worfklow these days so I may not.