search

sccn / roiconnect

ROI connectivity analysis in EEG
39 stars 17 forks source link

Arno #57

Closed arnodelorme closed 1 year ago

arnodelorme commented 1 year ago

Because we only apply this to continuous data, there is no real reason to modify the data itself. The resampling and epoching is an byproduct of the computation. So now we have an option to store the connectivity matrices and to keep the original continuous data.

nguyen-td commented 1 year ago

Makes a lot of sense, thanks for the change. I just realized that you may have introduced duplicate lines in your last PR, perhaps while resolving conflicts (which I just saw):

https://github.com/sccn/roiconnect/blob/ab733e552a0b5b13170195c97d9d8a9283458968/pop_roi_connect.m#L264-L274

It's basically the same as

https://github.com/sccn/roiconnect/blob/ab733e552a0b5b13170195c97d9d8a9283458968/pop_roi_connect.m#L249-L258

I remember fixing line 270 so 264-274 can be deleted.

I also fixed the following line https://github.com/sccn/roiconnect/blob/ab733e552a0b5b13170195c97d9d8a9283458968/pop_roi_connect.m#L278 to fc_name = g.methods{fc}; It would be great if you reverted that too.

arnodelorme commented 1 year ago

Yes, I have fixed that. Sorry about that. I get conflicts between branches and made a mistake when fixing it.

On Jul 20, 2023, at 8:07 PM, Tien Dung Nguyen @.***> wrote:

Makes a lot of sense, thanks for the change. I just realized that we you may have introduced duplicate lines in your last PR (which I just saw)?

https://github.com/sccn/roiconnect/blob/ab733e552a0b5b13170195c97d9d8a9283458968/pop_roi_connect.m#L264-L274

It's basically the same as

https://github.com/sccn/roiconnect/blob/ab733e552a0b5b13170195c97d9d8a9283458968/pop_roi_connect.m#L249-L258

I remember fixing line 270 so the 264-274 can be deleted.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.