PAC updates incl. bugfix, removed old scripts

nguyen-td commented 9 months ago

Renamed shuffle_MIM -> shuffle_CS to add clarity (the function is not limited to MIM)
Renamed pac_bispec -> data2bs_pac to add clarity and conform to naming convention
Removed some old scripts from Franziska that have been replaced
Added Franziska's BS shuffle functions
Add author to pop_roi_statsplot
Added important comments to data2bs_pac that clarify PAC computation from the BS
Added some To-Dos for Zixuan in shuffle_BS and data2bs_pac
Bugfix in computation of PAC over frequency bands
Update README

The things in shuffle_BS and partly in data2bs_pac are currently being edited. Shuffle_BS (the function to statistically evaluate PAC) is not working at the moment, but data2bs_pac (function to compute PAC) is. Overall, the statistical evaluation of PAC has just started.

I think it is important to push the bugfix though. PAC stuff can be tested through test_pipes/test_pac.m.

nguyen-td commented 8 months ago

I just saw that the history is not lost luckily. If I click on the renamed function there is a way to see the history of the old function https://github.com/sccn/roiconnect/commits/master/utils/shuffle_CS.m through Browse History But I will make sure to use git mv in the future.

arnodelorme commented 8 months ago

Ah good to know. Thanks,

Arno

On Dec 11, 2023, at 12:30 PM, Tien Dung Nguyen @.***> wrote:

I just saw that the history is not lost luckily. If I click on the renamed function there is a way to see the history of the old function https://github.com/sccn/roiconnect/commits/master/utils/shuffle_CS.m through Browse History But I will make sure to use git mv in the future.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.

sccn / roiconnect

PAC updates incl. bugfix, removed old scripts #70