search

sccn / xdf

BSD 2-Clause "Simplified" License
87 stars 34 forks source link

Fix error thrown when rcond is None in _jitter_removal #25

Closed agricolab closed 5 years ago

agricolab commented 6 years ago

The function load_xdf throws a type error, claiming None is not valid. Python 3.6.3 and Numpy 1.13.3

From scipy documentation:

rcond : float, optional

    Cut-off ratio for small singular values of a. Singular values are set to zero if they are smaller than rcond times the largest singular value of a.

I tested it with rcond=0 instead, and it worked.