search

sccn / xdf

BSD 2-Clause "Simplified" License
87 stars 34 forks source link

Uses appropriate numpy formats for stream values #38

Closed rstdm closed 5 years ago

rstdm commented 5 years ago

Hello, I noticed that pyxdf returns all numeric samples as numpy.float64 arrays even if the stream’s samples have a different format. This forces me to make needless casts and (in my opinion) is also error-prone. As fixing this issue shouldn’t break any existing scripts I simply did it myself.

Let me know if you are dissatisfied with my implementation or have any improvement suggestions.

cboulay commented 5 years ago

Hi @rstdm Do you mind moving this and your other PR to https://github.com/xdf-modules/xdf-Python?

cbrnr commented 5 years ago

I think this can be integrated in https://github.com/xdf-modules/xdf-Python/pull/2, so let's continue the discussion there.

cboulay commented 5 years ago

Fixed in https://github.com/xdf-modules/xdf-Python/pull/2