search

scdl-org / scdl

Soundcloud Music Downloader
GNU General Public License v2.0
3.37k stars 338 forks source link

Track Image #183

Closed hXtreme closed 7 years ago

hXtreme commented 7 years ago

Add optional parameters to include track image into the mp3 file metadata, or alternatively use playlist thumbnail as track image for all files downloaded from a playlist.

enhancement

flyingrub commented 7 years ago

The track image is already added to the track as id3tag. Could you provide more information on this issue ?

hXtreme commented 7 years ago

On checking the tag data, I find the image present but the Image doesn't show up in either Groove or Windows Media Player. AIMP sucessfully displays the image. scdlgroove scdltag scdlwmp scdlaimp

So the issue must be that the image probably doesn't comply with some Microsoft Standard. I'll verify whether the image data shows up on my mobile.

flyingrub commented 7 years ago

@hXtreme could we close this issue ? It seems related to windows media player and not scdl itself.

hXtreme commented 7 years ago

Okay, fine with me. One can just write a small script to fix this compatibility problem. So just in case, instead of closing it can you make it into something along the lines of optional fix or todo sometime later.

On Apr 30, 2017 3:26 PM, "Ronan" notifications@github.com wrote:

@hXtreme https://github.com/hXtreme could we close this issue ? It seems related to windows media player and not scdl itself. ❓

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/flyingrub/scdl/issues/183#issuecomment-298251534, or mute the thread https://github.com/notifications/unsubscribe-auth/AVYvG4tD4AiC2O4gzTuMLaNDkUEGPhO9ks5r1OBigaJpZM4M0lrd .

flyingrub commented 7 years ago

What kind of small script could fix this ? If you managed to fix feel free to open a PR or share you fix here :)

hXtreme commented 7 years ago

I have my finals right now so can't really help directly but my idea is:

  1. Extract cover image from the downloaded file.
  2. Encode image to a compatible format (probably using ImageMagick)
  3. Set the encoded image as cover

I haven't done much research on it but the following looked helpful to me: ImageMagik A short tutorial on how easy it is to use Adding the cover

EDIT: For extracting and setting image ffmpeg is a much better alternative than eyed3. Just from personal usage history. I used ffmpeg with youtube-dl and, it works pretty neat there. Usage for extracting image Usage for setting image