scdl-org / scdl

Soundcloud Music Downloader
GNU General Public License v2.0
3.29k stars 331 forks source link

cannot download as of 18/03 > yesterday was working fine :( #464

Closed durgenheim closed 5 months ago

durgenheim commented 5 months ago

error = Traceback (most recent call last): File "", line 198, in _run_module_as_main File "", line 88, in _run_code File "C:\Users\Mission Control\AppData\Local\Programs\Python\Python312\Scripts\scdl.exe__main__.py", line 7, in sys.exit(main()) ^^^^^^ File "C:\Users\Mission Control\AppData\Local\Programs\Python\Python312\Lib\site-packages\scdl\scdl.py", line 158, in main if not client.is_client_id_valid(): ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Users\Mission Control\AppData\Local\Programs\Python\Python312\Lib\site-packages\soundcloud\soundcloud.py", line 125, in is_client_id_valid next( StopIteration

plz halp

AshiraLOL commented 5 months ago

having the same error. did soundcloud update something new?

Traceback (most recent call last): File "", line 198, in _run_module_as_main File "", line 88, in _run_code File "C:\Users\Something\AppData\Local\Programs\Python\Python311\Scripts\scdl.exe__main__.py", line 7, in sys.exit(main()) ^^^^^^ File "C:\Users\Something\AppData\Local\Programs\Python\Python311\Lib\site-packages\scdl\scdl.py", line 158, in main if not client.is_client_id_valid(): ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Users\Something\AppData\Local\Programs\Python\Python311\Lib\site-packages\soundcloud\soundcloud.py", line 125, in is_client_id_valid next( StopIteration

Screenshot 2024-03-18 232737

KeithInvan commented 5 months ago

Linux code blowing the same errors, on the same line numbers with the exception of the first line, is Line 8, not Line 7.

Seems Soundcloud made a change.

poliana-girl commented 5 months ago

i'm also getting the same error ); really sad this broke because it was a really useful tool and it doesn't seem to have any active maintainers. i'd try and fix it myself but i would probably make it worse lol.

this works well in the meantime though:

yt-dlp --embed-metadata --embed-thumbnail https://soundcloud.com/artist/song

The only caveat is that if it downloads the original file it won't autoconvert it to flac, so it will just fail to add the thumbnail if the original file is a wav or aiff file. definitely not perfect but it's better than nothing!

Upon closer inspection i think this is a problem with the soundcloud library for python and not scdl itself? idk

7x11x13 commented 5 months ago

Should be fixed in v2.7.4

soundcloud seems to have removed the recent-tracks endpoint (RIP tag watching) which I was using to validate the client_id. I changed the validation method to just fetch some track instead.

gabhab commented 5 months ago

Amazing - thanks so much for fixing it so quickly!