scdl-org / scdl

Soundcloud Music Downloader
GNU General Public License v2.0
3.29k stars 331 forks source link

Original File downloads broken #483

Closed HeartbeatingForCenturies closed 3 months ago

HeartbeatingForCenturies commented 3 months ago

https://soundcloud.com/egoseed/wrongthoughts

Traceback (most recent call last):
  File "c:\python311\scripts\scdl-script.py", line 33, in <module>
    sys.exit(load_entry_point('scdl==2.7.4', 'console_scripts', 'scdl')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python311\Lib\site-packages\scdl-2.7.4-py3.11.egg\scdl\scdl.py", line 239, in main
    download_url(client, **python_args)
  File "C:\Python311\Lib\site-packages\scdl-2.7.4-py3.11.egg\scdl\scdl.py", line 344, in download_url
    download_track(client, track, exit_on_fail=kwargs.get("strict_playlist"), **kwargs)
  File "C:\Python311\Lib\site-packages\scdl-2.7.4-py3.11.egg\scdl\scdl.py", line 712, in download_track
    filename, is_already_downloaded = download_original_file(client, track, title, playlist_info, **kwargs)
                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python311\Lib\site-packages\scdl-2.7.4-py3.11.egg\scdl\scdl.py", line 535, in download_original_file
    url = client.get_track_original_download(track.id, track.secret_token)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python311\Lib\site-packages\soundcloud\soundcloud.py", line 280, in get_track_original_download
    download = self.requests["track_original_download"](track_id=track_id)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Python311\Lib\site-packages\soundcloud\soundcloud.py", line 448, in __call__
    r.raise_for_status()
  File "C:\Python311\Lib\site-packages\requests\models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url: https://api-v2.soundcloud.com/tracks/535045215/download?client_id=a3e059563d7fd3372b49b37f00a00bcf
adithayyil commented 3 months ago

Pretty sure you need to add a valid auth_token to your config file

Soundcloud Downloader
Found a track
Downloading WRONG.THOUGHTS
Downloading the original file.
[################################] 17137/17137 - 00:00:00
Setting tags...
WRONG.THOUGHTS.wav Downloaded.
7x11x13 commented 3 months ago

Pretty sure you need to add a valid auth_token to your config file

It seems this is the case now. We shouldn't try to download the original file if the auth token is not valid

7x11x13 commented 3 months ago

Changed in v2.7.10 so it won't try to download the original file if the auth token is invalid. If you want to download the original file make sure your auth token is valid