scean / noto

Automatically exported from code.google.com/p/noto
0 stars 0 forks source link

Code review request #292

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Branch name: dev_dougfelt_lint

Purpose of code changes on this branch:

lint fixes.

This refines the required character set for Nastaliq, which doesn't require 
full Arabic support. The character set is taken from Roozbeh's reference 
document.  It also changes the logic for the expected font names to include 
'Urdu' in the name for the Nastaliq font, and makes the style Nastaliq imply 
the script Arabic.

When reviewing my code changes, please focus on:

... whether code is in the right place.  This is kind of a patch, the logic 
wasn't set up for some of this behavior.  I decided to add yet another way to 
specify a character set rather than mock up a face unicode-format list of 
characters, and put some logic into the data file rather than make it simply a 
bunch of constants.

After the review, I'll merge this branch into:
n/a, I'll merge into master once I've dealt with all the fonts we have pending 
and changes to lint are reasonably stable.

Original issue reported on code.google.com by dougf...@google.com on 11 Mar 2015 at 1:55

GoogleCodeExporter commented 9 years ago
rb24d4576813a

Original comment by dougf...@google.com on 11 Mar 2015 at 8:52

GoogleCodeExporter commented 9 years ago

Original comment by jame...@google.com on 16 Mar 2015 at 5:16