Three fixes reported by therc

scele / rules_python

Experimental Bazel Python Rules

Apache License 2.0

2 stars 8 forks source link

Three fixes reported by therc #21

Closed scele closed 5 years ago

scele commented 5 years ago

Print helpful message if user runs :update without requirements_bzl attribute (Issue #17)
Don't generate empty __init__.py files (Issue #16)
- These can cause problems such as Issue #16.
Support adding new wheels via requirements_overrides (Issue #19)
- Sometimes it's convenient to add a new wheel via requirements_overrides, to add a user-built / self-hosted wheel, or to work around wheels that cannot be resolved. As an example of the latter case, add nvidia-ml-py which must be installed with "pip install nvidia-ml-py==375.53", but actually produces a wheel with version 375.53.1.
Bake files.pythonhosted.org URL into checked-in requirements.bzl for faster download

therc commented 5 years ago

I think the nvidia-ml-py problem is still there with the new digests = True.

Could not find a version that satisfies the requirement nvidia-ml-py==375.53.1
 (from -r /tmp/tmpw79vyQ (line 6))
 (from versions: 1.0, 2.285.1, 3.295.0, 4.304.2, 4.304.3, 4.304.4, 6.340.0, 7.346.0, 7.352.0, 375.53)

That code path seems to bypass wheel_overrides. Yeah, I know, I should keep away from brand new features...

scele commented 5 years ago

Yeah, I know, I should keep away from brand new features...

No you shouldn't! I should set up CI and not rely on my manual testing... Thanks for reporting this, very useful. Can you try again with the latest code from this PR?

therc commented 5 years ago

I have been experimenting with that code since Friday, but mostly by expanding the number of build targets, etc. I could only get it to work without digests enabled.

I had been able to get a bit past nvidia-ml-py. It was now choking during :update on gevent-1.1.1. For some reason, it was not a problem with digests=False. I bumped to a much newer gevent and it completed. Trying a large build now...