Closed sebastianludwig closed 7 years ago
Anyway, this is a potentially breaking change that probably requires users to adjust their implementation. Previously they could use Html.fromHtml(getString())
If they were using styling tags. Now they need to use Html.fromHtml(getText())
or just getText()
. Users that have been using Html.fromHtml(getText())
all along don't need to change anything. @jpm-polymorph, can you confirm that's the case?
@scelis should we start a change log?
Good catch @jpm-polymorph! 👍 I've updated the PR.
This LGTM! @sebastianludwig -- Mind creating a changelog.txt
file and add this to an upcoming version section? I think that's a great idea.
@scelis I've added a changelog.txt - are you happy with the format?
While creating it I realized I like having a change log a lot! It makes it so much easier to gauge if it's time for a release. Looking at the current list, do you think we should release a 0.10.2 containing all the small fixes and another release containing the breaking change?
About the breaking change: should we follow semantic versioning? Would #212 qualify as a "breaking change" and should we bump the major version? (isn't it time for Twine to mature to a 1.0 anyway? ;-))
👍
As for your other question, I'm not sure it's worth separating these out into two releases. I'm ok with merging all of these fixes in and then working toward a 1.0
@sebastianludwig how does that sound to you? Anything else holding us back from merging this PR?
I think it's good - go ahead 👍
I tried to follow our discussion and split up the regexp magic to make it easier to follow. @scelis do you think this is good enough? Any further suggestions?